mpldr
10. Mai 2023 um 07:07
21
Das liegt schlicht und ergreifend daran, dass ich spekulieren muss, was du meinst. Es wäre deutlich einfacher, wenn du erklären könntest, warum deiner Auffassung nach die bloße Anwesenheit einer Adresse im Quellcode bereits etwas negatives ist. (Vor allem, wenn es im Rahmen einer Blockliste ist.)
Um es anders zu formulieren:
„Für einen datenschutzfreundlichen Browser […], kann das nicht gut sein.“
„nicht gut“ unter welchem Gesichtspunkt?
Wenn Datenschutz: Wie würdest du begründen, dass die bloße Anwesenheit einer Domain negative Auswirkungen für den Datenschutz eines Browsers hat? (über ein „kann nicht gut sein“ hinaus)
Was sind die Auswirkungen der Strings in deinen Augen?
„bezüglich Codequalität“
Welche Metriken beziehst du für diese Einschätzung mit ein?
Wie beeinflusst die Anwesenheit eines Textschnipsels wie diesem die Qualität des gesamten Quellcodes?
Das würde ich einfach mal prüfen, ist ja einfach genug. Kommt dann als separate Antwort.
Zumindest in der von mir ausgecheckten Version nicht. In welcher Datei be welchem Commit hast du den String denn gefunden?
Solltest du meinen, dass die von dir gepostete URL ein gesponserter Link ist, so muss ich dir den Zahn leider ziehen. Das ist ein ganz normaler Amazon Link wie du ihn bekämst wenn du in der Suche auf ein Produkt klickst. Wie sponsored Links aussehen, kannst du in verschiedenen TK Posts sehen.
mpldr
10. Mai 2023 um 07:29
22
(aus offiziellem Repo: https://github.com/ungoogled-software/ungoogled-chromium)
Untersuchte Version: 113.0.5672.64-1
❯ rg -l www\\.amazon build/src ungoogled-chromium -> master
build/src/third_party/blink/perf_tests/parser/resources/final-url-en
build/src/third_party/google-closure-library/closure/goog/editor/link_test.js
build/src/components/omnibox/browser/history_quick_provider_unittest.cc
build/src/components/omnibox/browser/autocomplete_match.h
build/src/components/ntp_tiles/resources/default_popular_sites_with_popular_apps.json
build/src/components/test/data/password_manager/form_classification_tests/signup_forms_test.py
build/src/components/test/data/password_manager/form_classification_tests/signin_forms_test.py
build/src/components/bookmarks/browser/bookmark_model_unittest.cc
build/src/components/cast_receiver/browser/permissions_manager_impl_unittest.cc
build/src/components/favicon/core/fallback_url_util_unittest.cc
build/src/components/subresource_filter/core/common/perftests/data/http_archive_top_100_page_requests
build/src/net/base/registry_controlled_domains/effective_tld_names.dat
build/src/net/disk_cache/simple/simple_util_unittest.cc
build/src/net/http/transport_security_state_static.json
build/src/content/renderer/render_thread_impl_unittest.cc
build/src/ios/chrome/browser/autofill/automation/captured_sites/amazon.test
build/src/chrome/renderer/cart/commerce_hint_agent_browsertest.cc
build/src/chrome/renderer/cart/commerce_hint_agent_unittest.cc
build/src/chrome/android/javatests/src/org/chromium/chrome/browser/site_settings/WebsitePermissionsFetcherTest.java
build/src/chrome/browser/autocomplete/search_provider_unittest.cc
build/src/chrome/browser/cart/resources/cart_domain_cart_url_mapping.json
build/src/chrome/browser/cart/cart_service.cc
build/src/chrome/browser/cart/cart_service_unittest.cc
build/src/chrome/browser/ui/android/strings/android_chrome_strings.grd
build/src/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustSignalsEventStorageTest.java
build/src/chrome/tools/weburl_links.txt
build/src/url/url_parse_perftest.cc
build/src/tools/mac/power/scenarios.py
build/src/tools/perf/contrib/leak_detection/page_sets.py
build/src/tools/perf/contrib/leak_detection/data/leak_detection.json
build/src/tools/perf/page_sets/key_mobile_sites_smooth.py
build/src/tools/perf/page_sets/loading_mobile.py
build/src/tools/perf/page_sets/rendering/top_real_world_mobile.py
build/src/tools/perf/page_sets/alexa1-10000-urls.json
build/src/tools/perf/page_sets/rendering/top_real_world_desktop.py
build/src/tools/perf/page_sets/rendering/tough_pinch_zoom_cases.py
build/src/tools/perf/page_sets/system_health/accessibility_stories.py
build/src/tools/perf/page_sets/system_health/loading_stories.py
build/src/tools/perf/page_sets/system_health/browsing_stories.py
build/src/tools/perf/page_sets/v8_top_25.py
build/src/tools/perf/page_sets/top_25_smooth.py
build/src/tools/perf/page_sets/top_10.py
build/src/tools/perf/page_sets/intl_ja_zh.py
build/src/tools/perf/page_sets/data/top_25.json
build/src/tools/perf/page_sets/data/intl_ja_zh.json
build/src/tools/perf/page_sets/data/v8_top_25.json
build/src/tools/perf/page_sets/data/top_10.json
build/src/tools/perf/page_sets/loading_desktop.py
build/src/tools/perf/core/test_data/benchmarks_to_shard.json
build/src/tools/perf/core/test_data/test_timing_data.json
build/src/tools/perf/core/test_data/test_timing_data_1_build.json
build/src/tools/perf/core/shard_maps/timing_data/win-10-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/android-pixel2-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/mac-laptop_low_end-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/win-10_laptop_low_end-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/lacros-x86-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/mac-m1_mini_2020-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/android-pixel4_webview-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/android-pixel4-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/linux-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/android-pixel2_webview-perf_timing.json
build/src/tools/perf/core/shard_maps/timing_data/mac-laptop_high_end-perf_timing.json
build/src/tools/perf/page_sets/static_top_25/README.md
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25.reference/test_results.json
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25.reference/benchmark_log.txt
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25/test_results.json
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25.reference/perf_results.json
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25/benchmark_log.txt
build/src/tools/perf/testdata/task_output_dir/3/v8.runtime_stats.top_25/perf_results.json
❯ rg -l www\\.amazon build/src | wc -l ungoogled-chromium -> master
69
❯ rg -l google-analytics build/src ungoogled-chromium -> master
build/src/third_party/android_support_test_runner/runner/src/main/java/android/support/test/internal/runner/tracker/AnalyticsBasedUsageTracker.java
build/src/net/http/transport_security_state_static_pins.json
build/src/net/http/transport_security_state_static.json
build/src/net/tools/cache_transparency/sample_pervasive_payloads_list.csv
build/src/ash/webui/camera_app_ui/resources/js/type.ts
build/src/docs/security/post-spectre-webdev.md
build/src/chrome/browser/resources/chromeos/echo/manifest.json
build/src/components/test/data/autofill/heuristics/input/148_payment_dickblick.com.html
build/src/components/test/data/autofill/heuristics/input/118_checkout_cvs.com.html
build/src/components/test/data/autofill/heuristics/input/147_panera.custhelp.com_app_ask.html
build/src/components/test/data/dom_distiller/core_features.json
build/src/components/subresource_filter/core/common/perftests/data/http_archive_top_100_page_requests
❯ rg -l google-analytics build/src | wc -l ungoogled-chromium -> master
12
Amazon kommt häufiger, Google Analytics seltener, vor. Wenn du genau hinsiehst, siehst du auch gewisse Überschneidungen. Das liegt an etwas relativ einfachem: Brave und UGChromium sind Chromium und die Links sind Teil der Chromium Codebase. (Das heißt nicht, dass sie Teil von Chromium sind. Unit Tests werden nicht in das Programm einkompiliert)
Version: 662783:44770d5c9e91
❯ rg -l google-analytics | wc -l ~/Code/mozilla-central
21
❯ rg -l google-analytics ~/Code/mozilla-central
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/base.js
third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/base.js
testing/web-platform/tests/tools/third_party/py/doc/download.html
testing/web-platform/tests/tools/third_party/py/doc/_templates/layout.html
security/manager/ssl/StaticHPKPins.h
security/manager/ssl/nsSTSPreloadList.inc
browser/extensions/webcompat/shims/google-analytics-legacy.js
browser/extensions/webcompat/moz.build
browser/extensions/webcompat/manifest.json
browser/extensions/webcompat/data/shims.js
browser/base/content/test/caps/browser_principalSerialization_csp.js
services/settings/dumps/main/cookie-banner-rules-list.json
❯ rg -l www\\.amazon | wc -l ~/Code/mozilla-central
51
❯ rg -l www\\.amazon ~/Code/mozilla-central
third_party/python/aiohttp/vendor/http-parser/test.c
toolkit/modules/tests/xpcshell/test_NewTabUtils.js
netwerk/dns/effective_tld_names.dat
testing/condprofile/condprof/scenarii/urls.txt
testing/awsy/conf/tp6-pages.yml
testing/talos/talos/tests/tp5o.html
testing/talos/talos/tests/quantum_pageload/quantum_pageload_amazon.manifest
testing/talos/perfdocs/config.yml
testing/performance/pageload_sites.json
testing/performance/sites.txt
testing/perfdocs/generated/raptor.rst
testing/web-platform/tests/conformance-checkers/html-rdfa/0032-isvalid.html
testing/perfdocs/generated/talos.rst
testing/raptor/browsertime/pageload_sites.json
testing/raptor/raptor/tests/tp6/mobile/browsertime-tp6m.ini
testing/raptor/raptor/tests/tp6/desktop/browsertime-tp6.ini
testing/raptor/raptor/output.py
testing/raptor/raptor/tests/unittests/browsertime-tp6-unittest.ini
security/manager/ssl/nsSTSPreloadList.inc
intl/icu/source/i18n/astro.h
intl/icu/source/i18n/hebrwcal.h
dom/xml/test/old/books/books.xml
browser/components/search/extensions/amazon/_locales/au/messages.json
browser/components/search/extensions/amazon/_locales/jp/messages.json
browser/components/search/extensions/amazon/_locales/spain/messages.json
browser/components/search/extensions/amazon/_locales/ca/messages.json
browser/components/search/extensions/amazon/_locales/it/messages.json
browser/components/search/extensions/amazon/_locales/in/messages.json
browser/components/search/extensions/amazon/_locales/sweden/messages.json
browser/components/search/extensions/amazon/_locales/nl/messages.json
browser/components/search/extensions/amazon/_locales/france/messages.json
browser/components/search/extensions/amazon/_locales/en-GB/messages.json
browser/components/search/extensions/amazon/_locales/de/messages.json
browser/components/search/extensions/amazondotcom/_locales/us/messages.json
browser/components/search/extensions/amazondotcom/_locales/en/messages.json
browser/components/search/extensions/amazondotcn/manifest.json
browser/components/search/extensions/amazondotcn/_locales/default/messages.json
browser/components/search/extensions/amazondotcn/_locales/mozillaonline/messages.json
browser/components/extensions/test/browser/browser_ext_topSites.js
browser/components/newtab/lib/DefaultSites.jsm
browser/components/newtab/test/browser/head.js
browser/components/newtab/docs/v2-system-addon/remote_cfr.md
browser/components/search/test/browser/browser_searchEngine_behaviors.js
browser/components/search/test/unit/test_urlTelemetry.js
browser/components/urlbar/tests/browser/browser_urlbar_telemetry_sponsored_topsites.js
browser/components/urlbar/tests/browser/browser_top_sites_private.js
browser/components/urlbar/tests/browser/browser_top_sites.js
browser/components/urlbar/tests/browser/browser_urlbar_telemetry_topsite.js
browser/components/urlbar/content/preloaded-top-urls.json
js/src/tests/non262/regress/regress-89443.js
services/settings/dumps/main/top-sites.json
Ich lasse das jetzt unkommentiert stehen und hoffe du nimmst dir einen Moment nochmal darüber nachzudenken.
VIP
10. Mai 2023 um 14:31
23
Ich glaube, ich weiß, wer hier das Bier bezahlt…!
something to think about, thanks
